Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve File Browser #689

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Improve File Browser #689

merged 4 commits into from
Feb 15, 2024

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Feb 14, 2024

This improves multiple things:

  • Add tooltip to the icons
  • Fix a bug where we could only edit the path once then the button became useless
  • Change the settings icon to use the same as the Pharo menu one
  • Do not make the hiding of hidden files a filter but a setting impacting all filters. There is now an entry in the settings and also a command to toggle the value.

@hernanmd hernanmd self-requested a review February 15, 2024 10:37
hernanmd
hernanmd approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@hernanmd hernanmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok

@jecisc jecisc merged commit 1090eb3 into pharo-spec:Pharo12 Feb 15, 2024
1 of 2 checks passed
@jecisc jecisc deleted the improve-FileChoser branch February 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hernanmd hernanmd hernanmd approved these changes

Assignees

@estebanlm estebanlm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jecisc @hernanmd @estebanlm