Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing "Run to" debugger command from raising update events, in order to prevent unnecessary (and broken) updates #642

Conversation

adri09070
Copy link
Contributor

Fixes #607

In the debugger, "run to" from the debugger action model is doing steps on the debug session, which raise an update for each step.

However, to update the variable list in the inspector, the debugger uses the previousASTScope from the debugger action model, which isn't updated after each step when performing "run to". This could lead to duplicated temp variables when using "run to" to execute an inlined loop (see #607).

One simple solution is to prevent the debugger from updating after each step performed by the command, making only one big update after all steps instead.

This is cohesive with what the command should do because if we perform "run to" instead of steps, this is because we don't care of the intermediary updates.
This also makes the "run to" command A LOT faster.

The fix is for P12 but another similar fix should be done for P11 to fix #607 on P11

…to check that temps are not duplicated when using runTo when inlined blocks are involved
@StevenCostiou StevenCostiou merged commit cc9aaff into pharo-spec:Pharo12 Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Debugger: var duplication (and big slowdown) when executing a loop with "run to" action
2 participants