Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all the UIManager usage of StCritiqueBrowser to use Spec dialog i… #562

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

Ducasse
Copy link
Contributor

@Ducasse Ducasse commented Jul 2, 2023

…nstead.

@Ducasse Ducasse requested a review from estebanlm July 2, 2023 16:17
@Ducasse
Copy link
Contributor Author

Ducasse commented Jul 2, 2023

None of the broken tests are related.

MicPharoPackageCommentResourceReferenceTest
 ✗ #testLoadDirectory_emptyPrefix (18ms)

RBCodeSnippetTest
 ✗ #testStyler (6ms)
 ✗ #testStyler (2ms)

SystemDependenciesTest
 ✗ #testCollectionsShouldNotDependOnRandom (7099ms)
 ✗ #testExternalBasicToolsDependencies (7515ms)
 ✗ #testExternalCompilerDependencies (7741ms)
 ✗ #testExternalDisplayDependencies (7893ms)
 ✗ #testExternalFileSystemDependencies (7839ms)
 ✗ #testExternalIDEDependencies (8051ms)
 ✗ #testExternalKernelDependencies (8194ms)
 ✗ #testExternalLocalMonticelloDependencies (8198ms)
 ✗ #testExternalMetacelloDependencies (7480ms)
 ✗ #testExternalMonticelloDependencies (8037ms)
 ✗ #testExternalMorphicCoreDependencies (7866ms)
 ✗ #testExternalMorphicDependencies (7078ms)
 ✗ #testExternalSUnitDependencies (7175ms)
 ✗ #testExternalSUnitKernelDependencies (7697ms)
 ✗ #testExternalSpec2Dependencies (7393ms)
 ✗ #testExternalUFFIDependencies (7435ms)
 ✗ #testExternalUIDependencies (7309ms)
 ✗ #testFilesShouldNotDependOnRandom (7175ms)

@Ducasse Ducasse merged commit 9db0687 into Pharo12 Jul 2, 2023
@estebanlm
Copy link
Member

cool :)

@guillep guillep deleted the 2023-07-02-Bottom branch February 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants