Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup-debuggerColor #540

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Cleanup-debuggerColor #540

merged 1 commit into from
Jun 2, 2023

Conversation

MarcusDenker
Copy link
Contributor

debuggerColor is never used, it references SHRBTextStyler and one method even sends a non existing selector #debuggerColors

@MarcusDenker
debuggerColor is never used, it references SHRBTextStyler and one met…
71ff076 
…hod even sends a non existing selector #debuggerColors
StevenCostiou
StevenCostiou approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@StevenCostiou StevenCostiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was old code to change the color of the displayed node in the debugger.
This is not used anymore.

Failing tests seem unrelated.

@MarcusDenker MarcusDenker merged commit bfb783b into pharo-spec:Pharo12 Jun 2, 2023
@MarcusDenker MarcusDenker deleted the Cleanup-debuggerColor branch June 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenCostiou StevenCostiou StevenCostiou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcusDenker @StevenCostiou