Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change announcement api #502

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Apr 4, 2023

We changed the Announcement API

when: event do: action

by

when: event do: action for: subscriber

See pharo-project/pharo#13270 for more details

@PalumboN PalumboN changed the title Change announcement api #whenDisplayDo: -> #whenDisplayDo:for: Change announcement api Apr 4, 2023
@PalumboN PalumboN changed the title Change announcement api [WIP] Change announcement api Apr 4, 2023
@jecisc jecisc changed the base branch from Pharo11 to Pharo12 May 20, 2023 21:35
@jecisc
Copy link
Member

jecisc commented May 20, 2023

I rebased this one to Pharo12 branch.

I think it's good to merge. Is the "WIP" is the title still needed?

@PalumboN PalumboN changed the title [WIP] Change announcement api Change announcement api May 23, 2023
@PalumboN
Copy link
Contributor Author

Thanks @jecisc !

I checked the branch again with the current version of Pharo12 and it works, so yes, it's ok to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants