Skip to content
CI

Merge pull request #628 from hernanmd/minor-shell-enhacements #145

Sign in to view logs

Merge pull request #628 from hernanmd/minor-shell-enhacements

Merge pull request #628 from hernanmd/minor-shell-enhacements #145

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Pharo Launcher Tests succeeded Sep 20, 2023 in 0s

Pharo Launcher Tests ✅

Tests passed successfully

Report Passed Failed Skipped Time
PharoLauncher-Tests-Commands-Test.xml 56✅ 14s
PharoLauncher-Tests-Core-Test.xml 84✅ 9s
PharoLauncher-Tests-Download-Test.xml 35✅ 2s
PharoLauncher-Tests-Functional-Test.xml 51✅ 27s
PharoLauncher-Tests-SpecUI-Test.xml 32✅ 3s

✅ PharoLauncher-Tests-Commands-Test.xml

56 tests were completed in 14s with 56 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
PharoLauncher-Tests-Commands 56✅ 14s

✅ PharoLauncher-Tests-Commands

PharoLauncher.Tests.Commands.PhLAboutCommandTest
  ✅ testCanOpenAboutDialog
PharoLauncher.Tests.Commands.PhLCopyImageCommandTest
  ✅ testCanCopyImageLaunchCommand
PharoLauncher.Tests.Commands.PhLCopyLaunchCommandTest
  ✅ testCanCopyImageLaunchCommand
PharoLauncher.Tests.Commands.PhLCopyPathnameCommandTest
  ✅ testCanCopyImagePathname
PharoLauncher.Tests.Commands.PhLCreateImageFromTemplateCommandTest
  ✅ testCanCreateAnImageWhenSingleTemplateSelected
  ✅ testCanCreateAnImageWithAnInitializationScript
  ✅ testCannotCreateAnImageWhenManyTemplatesSelected
  ✅ testCannotCreateAnImageWhenNoTemplateSelected
PharoLauncher.Tests.Commands.PhLCreateTemplateFromImageCommandTest
  ✅ testCanCreateATemplateAndRemoveImageWhenSingleImageSelected
  ✅ testCanCreateATemplateWhenSingleImageSelected
PharoLauncher.Tests.Commands.PhLDeleteImageCommandTest
  ✅ testCanDeleteAnImage
  ✅ testDeleteTheRightImageIfImagesSortingIsNotTheDefaultOne
  ✅ testImagesPresenterIsRefreshedWhenImageDeleted
  ✅ testWarningMessageWhenDeletingManyImages
PharoLauncher.Tests.Commands.PhLDeleteVmCommandTest
  ✅ testCanDeleteAPrivateVM
  ✅ testCanDeleteAVM
  ✅ testCanDeleteManyPrivateVms
  ✅ testCanDeleteManyVms
PharoLauncher.Tests.Commands.PhLImportImageCommandTest
  ✅ testCanImportAnImage
  ✅ testImportImageImportsImageSourcesFile
  ✅ testImportImageImportsImageVersionFile
  ✅ testImportNonExistingImage
PharoLauncher.Tests.Commands.PhLLaunchImageCommandTest
  ✅ testAttachingAnInitializationScriptIsOk
  ✅ testAttachingInitializationScriptSetFlagToShouldRun
  ✅ testCanLaunchImage
  ✅ testExecutingImageWithScriptShouldSetFlagToShouldNotRun
  ✅ testRecreateAnImageWithoutOpeningItShouldStillExecuteScript
  ✅ testRecreateAnOpenedImageShouldStillExecuteScript
  ✅ testRunningAnImageRemovesTheInitializationScript
PharoLauncher.Tests.Commands.PhLLaunchImageFromDiskCommandTest
  ✅ testCanLaunchImageFromDisk
PharoLauncher.Tests.Commands.PhLOpenNewImageWindowTest
  ✅ testOfficialTemplatesCategoryIsSelectedWhenOpeningPresenter
  ✅ testTemplatesPresenterOpenWhenClickingOnNewImage
PharoLauncher.Tests.Commands.PhLOpenSettingsCommandTest
  ✅ testCanOpenSettingsBrowser
PharoLauncher.Tests.Commands.PhLRecreateImageCommandTest
  ✅ testCanRecreateAnImage
  ✅ testErrorRaiseWhenImageTemplateNotSet
PharoLauncher.Tests.Commands.PhLRefreshImagerepositoryCommandTest
  ✅ testCanRefreshImageList
PharoLauncher.Tests.Commands.PhLRemoveTemplateCommandTest
  ✅ testCanRemoveALocalTemplate
  ✅ testCanRemoveManyLocalTemplates
  ✅ testCommandAvailableWhenThereIsALocalTemplateSelected
  ✅ testCommandHasNoEffectWhenNoTemplateSelected
  ✅ testCommandNotAvailableWhenThereIsARemoteTemplateSelected
  ✅ testCommandNotAvailableWhenThereIsNoTemplateSelected
PharoLauncher.Tests.Commands.PhLRenameImageCommandTest
  ✅ testCanRenameAnImage
  ✅ testCannotRenameAnImageWithAnExistingName
PharoLauncher.Tests.Commands.PhLRenameTemplateCommandTest
  ✅ testCanRenameALocalTemplate
  ✅ testCommandAvailableWhenThereIsALocalTemplateSelected
  ✅ testCommandHasNoEffectWhenNoTemplateSelected
  ✅ testCommandNotAvailableWhenThereIsARemoteTemplateSelected
  ✅ testCommandNotAvailableWhenThereIsNoTemplateSelected
PharoLauncher.Tests.Commands.PhLShowImageInFolderCommandTest
  ✅ testCommandShouldNotRaiseCommandErrorIfNoImageSelected
PharoLauncher.Tests.Commands.PhLToggleVmPrivateVmCommandTest
  ✅ testPrivateVmsShownWhenButtonToggledOnce
  ✅ testVmsShownAtStartup
  ✅ testVmsShownWhenButtonToggledTwice
PharoLauncher.Tests.Commands.PhLUpdateVmCommandTest
  ✅ testCanUpdateManyPrivateVms
  ✅ testCanUpdateManyVms
  ✅ testCanUpdateOneVm

✅ PharoLauncher-Tests-Core-Test.xml

84 tests were completed in 9s with 84 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
PharoLauncher-Tests-Core 84✅ 9s

✅ PharoLauncher-Tests-Core

PharoLauncher.Tests.Core.PhLDirectoryBasedImageRepositoryTest
  ✅ testCopyImageNamedTo
  ✅ testCoverage
  ✅ testDeleteImageNamed
  ✅ testDirectoryForImageNamed
  ✅ testEmptyByDefault
  ✅ testIgnoreNonConformDirectories
  ✅ testImageNames
  ✅ testImages
  ✅ testMakeUniqueImageName
  ✅ testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses
  ✅ testNew
  ✅ testRenameImageNamedTo
  ✅ testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass
  ✅ testUnCategorizedMethods
PharoLauncher.Tests.Core.PhLImageDescriptionUpdaterTest
  ✅ testDoNotSaveNullImage
  ✅ testDoNotSaveWhenImageIsNil
  ✅ testNoSaveWhenDescriptionIsTheSame
  ✅ testSaveBothImagesWhenUpdatingDescriptionOfTwoDifferentImages
  ✅ testSaveOnceWhenDescriptionChangeOnce
  ✅ testSaveOnceWhenDescriptionChangesManyTimesWithDelayShorterThanWaitDelay
  ✅ testSaveTwiceWhenDescriptionChangesManyTimesWithDelayLongerThanWaitDelay
PharoLauncher.Tests.Core.PhLImageTest
  ✅ testCanGetDefaultLaunchConfigurationWhenNoLaunchConfiguration
  ✅ testCanInitializeImageFromMetadatafile
  ✅ testCanSerializeAndDeserializeImageLaunchConfigurationMetadata
  ✅ testCanSerializeAndDeserializeImageMetadata
  ✅ testDefaultLaunchConfigurationIsRetrievedFromConfigurationListWhenAvailable
  ✅ testDescriptionIsSetWhenNoDescriptionInMetadataButDescriptionFileExists
  ✅ testImageNameIsNotValidWhenContainingFileSeparator
  ✅ testImageNameIsValidWithLettersAndNumbers
  ✅ testPhLImageSerialization
  ✅ testPharoVersionIsSetWhenNoVersionInMetadataButPharoVersionFileExists
  ✅ testTemplateIsSetWhenMetadataFileInOldFormat
PharoLauncher.Tests.Core.PhLLaunchConfigurationTest
  ✅ testCanGetDefaultVm
  ✅ testCanGetDefaultVmWhenVMNotListedInVmManager
  ✅ testCanSerializeLaunchConfiguration
  ✅ testImageLaunchProcessDoesNotHaveInitializationScriptArgumentsIfInitializationScriptIsNil
  ✅ testImageLaunchProcessDoesNotHaveInitializationScriptArgumentsIfInitializationScriptShouldNotBeRun
  ✅ testImageLaunchProcessHasImageArguments
  ✅ testImageLaunchProcessHasInitializationScriptArgumentsIfInitializationScriptNotNil
  ✅ testImageLaunchProcessHasVmArguments
  ✅ testImageLaunchWitSettingsDoesNotHaveNoPreferencesFlag
  ✅ testImageLaunchWithoutSettingsDoesNotHavePreferencesFlagIfNotSupportedByImage
  ✅ testImageLaunchWithoutSettingsHasNoPreferencesFlag
  ✅ testVmHasSameVmManagerAsImage
PharoLauncher.Tests.Core.PhLLocalTemplateTest
  ✅ testCoverage
  ✅ testDeserializationGivesAFileReferenceToTheTemplate
  ✅ testHandleEOCDErrorWhenTemplateIsCorrupted
  ✅ testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses
  ✅ testNew
  ✅ testNoEOCDErrorWhenTemplateIsOk
  ✅ testRelocateImageFilesFromToWithName
  ✅ testSerializationDoesNotIncludeZipFileButAFileReferenceToIt
  ✅ testTemplateExtractionGenerateImageMetadata
  ✅ testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass
  ✅ testUnCategorizedMethods
PharoLauncher.Tests.Core.PhLRemoteTemplateTest
  ✅ testCoverage
  ✅ testHandleEOCDErrorWhenTemplateIsCorrupted
  ✅ testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses
  ✅ testNew
  ✅ testNoEOCDErrorWhenTemplateIsOk
  ✅ testRelocateImageFilesFromToWithName
  ✅ testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass
  ✅ testUnCategorizedMethods
PharoLauncher.Tests.Core.PhLStringTest
  ✅ testCanformatTemplateNameFromComplexUrl
  ✅ testCanformatTemplateNameFromComplexUrl2
  ✅ testCanformatTemplateNameFromSimpleUrl
  ✅ testFormatTemplateNameDoesNotSubsituteWhenNoSubstitutionPatternFound
PharoLauncher.Tests.Core.PhLTemplateGroupsBuilderTest
  ✅ testCanBuildListWhenNoSourceTemplate
  ✅ testCanBuildListWithFixedUrlGroup
  ✅ testCanBuildListWithFixedUrlTemplate
  ✅ testCanBuildListWithHttpListingGroup
  ✅ testCanBuildListWithJenkinsGroup
PharoLauncher.Tests.Core.PhLTemplateSourcesTest
  ✅ testAlmostIdenticalTemplateSourcesAreDifferent
  ✅ testCanCreateInstanceFromAListOfTemplateSource
  ✅ testCanFetchSourcesFileWhenAbsent
  ✅ testGivenUserSourcesFileAbsentWhenAskingUserSourcesThenGetEmptyCollection
  ✅ testGivenUserSourcesFileWithErrorsWhenAskingUserSourcesThenGetEmptyCollection
  ✅ testGivenUserSourcesFileWithReferencesToUnknownVariablesWhenAskingUserSourcesThenGetEmptyCollection
  ✅ testIdenticalTemplateSourcesAreEquals
  ✅ testNoUpdateAnnouncedWhenDownloadedSourcesIsSameAsSources
  ✅ testSourcesFileNotFetchIfPresentWhenCallingEnsureSourcesFile
  ✅ testSourcesFileNotUpdatedWhenDownloadedSourcesFileIsAbsent
  ✅ testSourcesFileUpdateAvailableIsAnnouncedWhenDownloadedSourcesDifferentFromSources
  ✅ testUserTemplatesAreListedAfterPharoTemplates

✅ PharoLauncher-Tests-Download-Test.xml

35 tests were completed in 2s with 35 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
PharoLauncher-Tests-Download 35✅ 2s

✅ PharoLauncher-Tests-Download

PharoLauncher.Tests.Download.PhLJenkins2BuildTest
  ✅ testBuildWithArtifacts
  ✅ testBuildWithRuns
  ✅ testEmptyBuild
  ✅ testLastSuccessfulBuildPropagateTag
  ✅ testNonSecureJenkinsDoesNotIncludesIdentifiersInUrl
  ✅ testSecureJenkinsIncludesIdentifiersInUrl
PharoLauncher.Tests.Download.PhLJenkins2JobTest
  ✅ testJobWithNoSuccessfulBuild
  ✅ testJobWithNullSuccessfulBuild
  ✅ testJobWithSuccessfulBuild
  ✅ testNonSecureJenkinsDoesNotIncludesIdentifiersInUrl
  ✅ testPipelineJob
  ✅ testSecureJenkinsIncludesIdentifiersInUrl
PharoLauncher.Tests.Download.PhLJenkins2RunTest
  ✅ testNonSecureJenkinsDoesNotIncludesIdentifiersInUrl
  ✅ testSecureJenkinsIncludesIdentifiersInUrl
PharoLauncher.Tests.Download.PhLJenkins2ServerTest
  ✅ testNoJob
  ✅ testNonSecureJenkinsDoesNotIncludesIdentifiersInUrl
  ✅ testSecureJenkinsIncludesIdentifiersInUrl
  ✅ testWith1Job
PharoLauncher.Tests.Download.PhLVirtualMachineManagerTest
  ✅ testCanDetect32BitsImage
  ✅ testCanDetect64BitsImage
  ✅ testCanGetImageFormatNumber
  ✅ testCanGetImageVersionFromFile
  ✅ testGetExceptionWhenRunningImageVersionFromFileWhenFileIsAbsent
  ✅ testImageVersionDeterminationScriptIsUpdatedWhenFileContentDifferentFromScriptInImage
  ✅ testPharo50PreSpurImageUrlIsCorrect
  ✅ testPharo60VmUrlIsCorrect
  ✅ testPharo70Vm64BitsUrlIsCorrect
  ✅ testPharo70VmUrlIsCorrect
  ✅ testPreSpurImageUrlIsCorrect
PharoLauncher.Tests.Download.PhLVmProviderTest
  ✅ testCanDetectArchitecture
  ✅ testCanDetectOS
  ✅ testLatestUrlIsValidAndAvailable
  ✅ testStableUrlIsValidAndAvailable
PharoLauncher.Tests.Download.PhLVmProviderUntilPharo80Test
  ✅ testUrlIsValidAndAvailable
  ✅ testUrlIsValidAndAvailableWhenOs64BitAndImageAvailableOnlyIn32Bits

✅ PharoLauncher-Tests-Functional-Test.xml

51 tests were completed in 27s with 51 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
PharoLauncher-Tests-Functional 51✅ 27s

✅ PharoLauncher-Tests-Functional

PharoLauncher.Tests.Functional.PhLCreateTemplateFromImageTest
  ✅ testCanCreateATemplateFromImage
PharoLauncher.Tests.Functional.PhLDownloadManagerTest
  ✅ testCanDownload
PharoLauncher.Tests.Functional.PhLHTTPListingTemplateGroupTest
  ✅ testCoverage
  ✅ testIsGroup
  ✅ testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses
  ✅ testNew
  ✅ testTemplatesAndGroups
  ✅ testTemplatesAndGroupsIsACollection
  ✅ testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass
  ✅ testUnCategorizedMethods
PharoLauncher.Tests.Functional.PhLLaunchImageTest
  ✅ testArchitectureErrorSignaledWhenTryingToRun32BitImageOn64BitOnlyOS
  ✅ testCanLaunchImageWithNonAsciiCharacters
  ✅ testCanLaunchImageWithNonAsciiCharactersUsingLoginShell
  ✅ testCanRun64bitImageOn64BitOnlyOS
  ✅ testLaunchImageSetShouldRunInitilizationScriptToFalse
PharoLauncher.Tests.Functional.PhLLaunchedImagesWatcherTest
  ✅ testCanCatchProcessError
  ✅ testProcessSuccessfulDoesNotThrowError
PharoLauncher.Tests.Functional.PhLPrivateVirtualMachineTest
  ✅ testCanGetDownloadUrl
PharoLauncher.Tests.Functional.PhLProcessWrapperTest
  ✅ testCanDetectAvailableCommandOnLinux
  ✅ testCanDetectAvailableCommandOnWindows
  ✅ testCanRunCommandWithNonAsciiCharacters
  ✅ testLinuxCommandLineString
  ✅ testLinuxCommandLineStringWhenUsingShell
  ✅ testLinuxCommandRemoveDoubleQuotesFromArguments
  ✅ testLinuxShellCommandDoesNotRemoveDoubleQuotesFromArguments
  ✅ testRunningInfiniteProcessThrowsTimeout
  ✅ testRunningShortProcessDoesNotTimeout
  ✅ testWindowsCommandDoesNotRemoveDoubleQuotesFromArguments
  ✅ testWindowsCommandLineString
  ✅ testWindowsCommandLineStringWhenUsingShell
  ✅ testWindowsShellCommandOnWindowsDoesNotRemoveDoubleQuotesFromArguments
PharoLauncher.Tests.Functional.PhLUnixSubprocessTest
  ✅ testCanGetExitStatusFromLaunchCommand
  ✅ testCanGetStdErrFromLaunchCommand
PharoLauncher.Tests.Functional.PhLVirtualMachineManagerFunctionalTest
  ✅ testCanDetectPreSpurImage
  ✅ testCanDetectSystemUnzip
  ✅ testCanGetImageVersion
  ✅ testCanGetImageVersionFromFileWhenRunningExtraVM
  ✅ testCanGetImageVersionFromFileWithRightCommand
  ✅ testCanGetImageVersionFromPharo14Image
  ✅ testGetExceptionWhenRunningImageVersionFromFileWithBadCommand
  ✅ testImageVersionDeterminationIsRunWithoutSettings
PharoLauncher.Tests.Functional.PhLVirtualMachineTest
  ✅ testCanDetect32BitArchPath
  ✅ testCanDetect64BitArchPath
  ✅ testCanDetectExecutablePath
  ✅ testCanDetectVMDirectory
  ✅ testCanGetDownloadUrl
  ✅ testCanGetExecutablePathWhenBeeingSerializedAsString
  ✅ testCanGetPharoVersion
  ✅ testSerialization
  ✅ testvm10IsGreaterThanVm1
  ✅ testvm64IsGreaterThanVm32

✅ PharoLauncher-Tests-SpecUI-Test.xml

32 tests were completed in 3s with 32 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
PharoLauncher-Tests-SpecUI 32✅ 3s

✅ PharoLauncher-Tests-SpecUI

PharoLauncher.Tests.SpecUI.PhLImageCreationPresenterTest
  ✅ testImageNameIsNotValidWhenContainingFileSeparator
  ✅ testImageNameIsValid
  ✅ testInitializationScriptListUpdatedWhenScriptPresenterDoChange
PharoLauncher.Tests.SpecUI.PhLImagesPresenterTest
  ✅ testFirstImageIsSelectedAtOpening
  ✅ testImageLaunchConfigurationsAreUpdatedAfterLaunchConfigurationEdition
  ✅ testImageLaunchConfigurationsIsUpdatedAfterSortingOfImages
  ✅ testImagesPresenterIsRefreshedWhenApplicationNotifyImageRepositoryChanged
  ✅ testLaunchCommandIsDisabledWhenNoSelection
  ✅ testNewImagesIsSelectedWhenNewImageJustCreated
PharoLauncher.Tests.SpecUI.PhLLaunchConfigurationPresenterTest
  ✅ testCanOpenAPresenterWithVMNotInDefaultListNorOnDisk
  ✅ testConfigurationDetailIsCleanedWhenConfigurationDeleted
  ✅ testEditingAndSavingAConfigurationSelectsItInImagesPresenterToolbar
  ✅ testImageInteractiveArgumentIsAddedWhenHeadlessVMSelectedAndArgumentNotAlreadyPresent
  ✅ testImageInteractiveArgumentIsNotAddedWhenHeadlessVMSelectedAndArgumentAlreadyPresent
  ✅ testImageLaunchConfigurationsUpdatedWhenConfigurationAdded
  ✅ testImageLaunchConfigurationsUpdatedWhenConfigurationRemoved
  ✅ testRemoveImageArgument
  ✅ testRemoveImageArgumentWithoutSelectionDoesNotThrowError
  ✅ testRemoveVMArgument
  ✅ testRemoveVMArgumentWithoutSelectionDoesNotThrowError
  ✅ testSelectingAConfigurationAndClosingWindowSelectsItInImagesPresenterToolbar
  ✅ testVmsAreSortedById
  ✅ testWhenOpeningPresenterThenSelectedConfigurationIsDefaultConfiguration
PharoLauncher.Tests.SpecUI.PhLScriptPresenterTest
  ✅ testCanAddNewScript
  ✅ testCanRemoveScript
  ✅ testCanSaveScript
  ✅ testCannotRemoveScriptIfNoneSelected
  ✅ testNewScriptEndsWithStExtension
  ✅ testSaveScriptUsingKeybind
PharoLauncher.Tests.SpecUI.PhLTemplatesPresenterTest
  ✅ testCanCreateImageIfOneTemplateSelected
  ✅ testCannotCreateImageIfNoTemplateSelected
  ✅ testTemplatesPresenterClosesWhenClickingOnCreateImage
View more details on GitHub Actions