Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "Show" when no image is downloaded yet gives error #570

Closed
astares opened this issue Jun 8, 2022 · 1 comment · Fixed by #571
Closed

Use "Show" when no image is downloaded yet gives error #570

astares opened this issue Jun 8, 2022 · 1 comment · Fixed by #571
Labels
Bug

Comments

@astares
Copy link
Member

astares commented Jun 8, 2022

  • open a fresh new Pharo launcher when no image has been downloaded yet and click on the "Show" button on the toolbar:

image

image
@astares astares added the Bug label Jun 8, 2022
@astares
Copy link
Member Author

astares commented Jun 8, 2022

It would be good if we could guard this case in the method #execute in PhLShowImageInFolderCommand
like

execute
	self imagesPresenter hasSingleImageSelected ifFalse: [ ^self ].
	self imagesPresenter singleImage showNativeFolder

image

astares added a commit to astares/pharo-launcher that referenced this issue Jun 8, 2022
@astares
Use "Show" when no image is downloaded yet gives error
95d606b 
Fix pharo-project#570
@astares astares mentioned this issue Jun 8, 2022
Merged
demarey pushed a commit that referenced this issue Jun 9, 2022
@astares
Use "Show" when no image is downloaded yet gives error (#571)
13b8fde 
Fix #570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use "Show" when no image is downloaded yet gives error astares/pharo-launcher
1 participant
@astares