Do not try to guess image pharo version. Too unreliable.

src/PharoLauncher-Core/PhLImage.class.st

@@ -392,12 +392,10 @@ PhLImage >> launchWithConfiguration: aPhLLaunchConfiguration [
 			^ self ].
 	architectureWarningEnabled := true.
 	continue := true.
-	[ [ | processWrapper|
+	[ | processWrapper|
 		processWrapper := (aPhLLaunchConfiguration launchProcess) runUnwatch.
 		self doNotRunInitializationScript. "Just run, image already initialized"
 		^ processWrapper ]
-	on: PhLImageVersionDeterminationError
-	do: [ :error | error uiAlert ] ]
 	on: PhLArchitectureMismatchWarning
 	do: [ :warning |
 		architectureWarningEnabled ifTrue: [ 	

src/PharoLauncher-Core/PhLImageVersionFileNotFound.class.st

@@ -0,0 +1,22 @@
+"
+Error thrown when Pharo Launcher did not succeed to determine the Pharo version of the image to launch.
+Probably, the run command failed.
+I hold the command run to determoine the version so that it can be reused for debugging purposes.
+"
+Class {
+	#name : #PhLImageVersionFileNotFound,
+	#superclass : #PhLError,
+	#category : #'PharoLauncher-Core-Download'
+}
+
+{ #category : #accessing }
+PhLImageVersionFileNotFound >> longDescription [
+	^ PhLImage versionFileName , 
+	' file was not found for your image, and probably your VMs are not up to date.
+Please, contact us at http://pharo.org/community'
+]
+
+{ #category : #accessing }
+PhLImageVersionFileNotFound >> name [
+	^ 'Image version file ', PhLImage versionFileName , ' not found!'
+]

src/PharoLauncher-Core/PhLLaunchConfiguration.class.st

@@ -92,7 +92,7 @@ PhLLaunchConfiguration >> commandString [
 
 { #category : #querying }
 PhLLaunchConfiguration >> defaultVm [
-	self image ensurePharoVersion.
+	self image pharoVersion.
 	^ self image vmManager virtualMachine
 ]
 
@@ -128,7 +128,8 @@ PhLLaunchConfiguration >> initializeWithImage: anImage [
 	image := anImage.
 	name := 'new configuration...'.
 	usePharoSettings := true.
-	imageArguments := anImage defaultArguments
+	imageArguments := anImage defaultArguments.
+	image ensurePharoVersion
 ]
 
 { #category : #testing }
@@ -168,7 +169,7 @@ PhLLaunchConfiguration >> printOn: aStream [
 { #category : #configuring }
 PhLLaunchConfiguration >> useSettings: aBoolean [
 	"Cannot skip Pharo settings before Pharo 3.0"
-	self image ensurePharoVersion asInteger < 30 ifTrue: [ ^ self ].
+	self image pharoVersion asInteger < 30 ifTrue: [ ^ self ].
 
 	usePharoSettings := aBoolean.
 ]

src/PharoLauncher-Core/PhLLaunchImageCommand.class.st

@@ -129,8 +129,7 @@ PhLLaunchImageCommand >> launchConfigurationOfImage: aPhLImage [
 PhLLaunchImageCommand >> launchImage: aPhLImage [
 	| process launchConfig |
 
-	[ 
-		launchConfig := self launchConfigurationOfImage: aPhLImage.
+	[  launchConfig := self launchConfigurationOfImage: aPhLImage.
 		launchConfig useSettings: useSettings.
 		process := aPhLImage launchWithConfiguration: launchConfig ]
 	on: PhLError

src/PharoLauncher-Core/PhLVirtualMachine.class.st

@@ -41,18 +41,14 @@ Class {
 
 { #category : #'instance creation' }
 PhLVirtualMachine class >> directory: aFileReference [
-	^ self 
-		directory: aFileReference
-		private: false
-]
 
-{ #category : #'instance creation' }
-PhLVirtualMachine class >> directory: aFileReference private: isPrivateVm [
 	| targetClass |
-	targetClass := self allSubclasses detect: [ :cls | cls isSubclassForDirectory: aFileReference private: isPrivateVm ] ifNone: [ self ].
-	^ targetClass new 
-		initializeOn: aFileReference;
-		yourself 
+	targetClass := self allSubclasses
+		               detect: [ :cls | cls isSubclassForDirectory: aFileReference ]
+		               ifNone: [ self ].
+	^ targetClass new
+		  initializeOn: aFileReference;
+		  yourself
 ]
 
 { #category : #accessing }
@@ -80,9 +76,9 @@ PhLVirtualMachine class >> id: aString [
 ]
 
 { #category : #testing }
-PhLVirtualMachine class >> isSubclassForDirectory: aFileReference private: isPrivateVm [
+PhLVirtualMachine class >> isSubclassForDirectory: aFileReference [
 
-	^ isPrivateVm not and: [ aFileReference basename beginsWith: self versionPrefix ]
+	^ aFileReference basename beginsWith: self versionPrefix
 ]
 
 { #category : #accessing }