move failing tests in a dedicated package

pharo-project · Nov 15, 2023 · 6499378 · 6499378
1 parent e4def26
commit 6499378
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/src/BaselineOfPharoLauncher/BaselineOfPharoLauncher.class.st b/src/BaselineOfPharoLauncher/BaselineOfPharoLauncher.class.st
@@ -41,6 +41,8 @@ BaselineOfPharoLauncher >> baseline: spec [
 				spec requires: #('PharoLauncher-Tests-Core' ). ];
 			package: 'PharoLauncher-Tests-Functional' with: [
 				spec requires: #('PharoLauncher-Core' 'PharoLauncher-Tests-Download'). ];
+			package: 'PharoLauncher-Tests-Functional-Debug' with: [
+				spec requires: #('PharoLauncher-Tests-Functional' 'PharoLauncher-Core' 'PharoLauncher-Tests-Download'). ];
 			package: 'PharoLauncher-CLI' with: [ 
 				spec requires: #('Clap') ];
 			package: 'PharoLauncher-CLI-Tests' with: [ 
@@ -53,6 +55,7 @@ BaselineOfPharoLauncher >> baseline: spec [
 				'PharoLauncher-Spec2' 
 				'PharoLauncher-Tests-SpecUI' 
 				'PharoLauncher-Tests-Functional'
+				'PharoLauncher-Tests-Functional-Debug'
 				'PharoLauncher-CLI-Tests' 
 				'PharoLauncher-GToolkit' 
 				'PharoLauncher-Squeak') ]

diff --git a/src/PharoLauncher-Core/PhLVirtualMachineManager.class.st b/src/PharoLauncher-Core/PhLVirtualMachineManager.class.st
@@ -381,7 +381,7 @@ PhLVirtualMachineManager >> imageVersion [
 		[ [ self imageVersionFromFile ]
 			on: PhLImageVersionDeterminationError
 			do: [ "no version file, generate it"
-					[ self imageVersionFromFileWith: (self imageVersionCommandWithPreferences: false) ]
+					[ 1 halt. self imageVersionFromFileWith: (self imageVersionCommandWithPreferences: false) ]
 						on: PhLImageVersionDeterminationError, PhLProcessTimeOut
 						do: [ "Command probably failed, try to run without --no-default-preferences option (only available since Pharo 3.0)"
 								self imageVersionFromFileWith: (self imageVersionCommandWithPreferences: true) ] ] ]

diff --git a/...tualMachineManagerFunctionalTest.class.st → ...tualMachineManagerFunctionalTest.class.st b/...tualMachineManagerFunctionalTest.class.st → ...tualMachineManagerFunctionalTest.class.st
@@ -8,7 +8,7 @@ Class {
 		'vmStoreBackup',
 		'tempVmStoreFolder'
 	],
-	#category : #'PharoLauncher-Tests-Functional'
+	#category : #'PharoLauncher-Tests-Functional-Debug'
 }
 
 { #category : #accessing }
@@ -49,7 +49,7 @@ PhLVirtualMachineManagerFunctionalTest >> testCanGetImageVersion [
 	self timeLimit: 30 seconds.
 
 	PhLVirtualMachineManagerTestResource current 
-		withCopyOfPharo90ImageDo: [ :imageRef | 
+		withCopyOfPharo90ImageDo: [ :imageRef | 1 halt.
 			version := (PhLVirtualMachineManager forImage: imageRef)
 				           imageVersion.
 			self assert: version equals: '90' ]

diff --git a/src/PharoLauncher-Tests-Functional-Debug/package.st b/src/PharoLauncher-Tests-Functional-Debug/package.st
@@ -0,0 +1 @@
+Package { #name : #'PharoLauncher-Tests-Functional-Debug' }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Package { #name : #'PharoLauncher-Tests-Functional-Debug' }