-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ux] Verify input to all AMD tools #1162
[ux] Verify input to all AMD tools #1162
Conversation
Codecov ReportBase: 84.79% // Head: 85.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 84.79% 85.27% +0.48%
==========================================
Files 291 292 +1
Lines 26460 26841 +381
Branches 4513 4583 +70
==========================================
+ Hits 22436 22890 +454
+ Misses 3303 3218 -85
- Partials 721 733 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7f2bcbe
to
acb7df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd maybe add types when raising type errors so that it is clear why that error is happening! Another question, in the Files changed it said modeling.init and tools.init are empty, were they removed or do you know why they're in the Files changed?
These new empty files are needed by |
7752de7
to
869d131
Compare
85d4864
to
93a11d4
Compare
This is now checked automatically from create_workflow function signature annotations.
Current usage never needs this since we always pass the model object to create_workflow. This also simplifies the current implementation. In the future, when we want to automate this sort of input validation at workflow start for all tools,we can revisit this more generally.
93a11d4
to
b4c82ae
Compare
The goal is to improve the UX of the different tools when tool inputs are incorrect.
run_amd
or othercreate_workflow
tovalidate_input
create_workflow
's signature's annotationsmodelsearch
(See point 1 in Error message during run_modelsearch #1163 (comment))covsearch
(Test with Covariate tool #1178 (comment))