Closes #2521 remove lifecycle deprecation code for get summary records

[jimrothstein]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue in the Development Section on the right hand side.
• Address all merge conflicts and resolve appropriately
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[jimrothstein]

#2521 - First attempt:

Removing lifecycle deprecation code for get_summary_records() now allows user to use deprecated formal arguments, which don't think you intended.

Could you clarify, please?

[github-actions]

Package	Line Rate	Health
admiral	97%	✔
Summary	97% (5060 / 5214)	✔

[bms63]

Please remove argument from function and related code.

also good to check tests for the argument to see if those need to be excised.

I don’t think this function gets called by user but always good to check vignettes and templates

oh and the documentation - should be cleaned up as well

thanks!!

[bms63]

@jimrothstein This new test you have included is not needed.

We have been letting users know for about a year that these arguments are being removed from this admiral function. We have a pretty generous timeline for deprecating stuff. Once we conclude the deprecation timeline we remove everything from the function, any tests, documentation, etc and we no longer need to do anything to support it.

Unless I am missing something?

[bms63]

And many thanks for jumping in here!! we try to follow tidyverse deprecation guidelines, but we are more conservative. New deprecation timelines are coming that are multi-year!! eeckkk!!

[jimrothstein]

Removed unneeded test... understood!

derive_param_exposure.R

• I need to adjust this function's documentation. (It references the two vanished variables)

locally, test admiral throwing errors

• will investigage

[bundfussr]

Please add an item to NEWS.md

[bundfussr]

derive_param_exposure.R

• I need to adjust this function's documentation. (It references the two vanished variables)

Good catch! It seems that we missed it before.

[bms63]

Suggested change

	- In `get_summary_records()`, previously deprecated formal arguments `analysis_var` and `summary_fun` now removed from function, documentation, tests etc.
	- In `get_summary_records()`, previously deprecated formal arguments `analysis_var` and `summary_fun` now removed from function, documentation, tests etc. (#2521)

[bms63]

We are close!! I scan for the deprecated arguments in the repo and think we might need to look at derive_param_exposure

[jimrothstein]

Suggestion (for now or future)

Replace

@return The input dataset with a new record added for each group (with respect to the variables
#' specified for the by_vars parameter).

With
@return The input dataset with a new record added for each group (as defined by by_vars parameter).

[jimrothstein]

@bms63

Something I did ? (I use linux)