Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.4 to v.5.1.4 update #166

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open

v.4 to v.5.1.4 update #166

wants to merge 72 commits into from

Conversation

shenyman
Copy link

There is only master branch and no v.4 branch, as mentioned in the readme NOTE. You may create one or merge and update the vokuro.

@shenyman
Update README.md
f1d5c2e
@shenyman
Update Helpers.php
1a8e46b
@shenyman
Update config.php
a587826
@shenyman
Update ConfigProvider.php
f2b2632
@shenyman
Update DbProvider.php
6dd97dc
@shenyman
Update AssetsProvider.php
11ae1a3
@shenyman
Update UrlProvider.php
dff146c
@shenyman
Update FlashProvider.php
bffaa95
@shenyman
Update SignUpForm.php
20cfaa1
@shenyman
Update SecurityProvider.php
01c81f5
@shenyman
Update Users.php
146ccd9
@shenyman
Update LoginForm.php
eedd01c
@shenyman
Update ProfilesForm.php
75070e8
@shenyman
Update ChangePasswordForm.php
1f5fb87
@shenyman
Update ForgotPasswordForm.php
285b894
@shenyman
Update UsersForm.php
05657a3
@shenyman
Update LoggerProvider.php
31c723f
@shenyman
Update ViewProvider.php
0323d15
@shenyman
Update composer.json
e46fbc9
@shenyman
Update search.volt
8c395f2
@shenyman
Update search.volt
b22744b
@shenyman
Update composer.json
aca97aa
@shenyman
Update README.md
7efdb31
@shenyman
Update SessionBagProvider.php
346562b
@shenyman
Update PermissionsController.php
30c74a5
@shenyman
Update PermissionsController.php
11fa395
@niden
Copy link
Member

niden commented Jan 18, 2023

@shenyman can you please check phpcs for the PermissionsController?

@shenyman
Copy link
Author

@shenyman can you please check phpcs for the PermissionsController?

Apologies! Won't PR without phpcs checks anymore!

@niden
Copy link
Member

niden commented Jan 28, 2023

I am sure there is a way to PR my fork, but don't do it since you did a lot of work on this one already. Let's get this done with tests passing and then we can see stuff that we might want to change from the other PR etc.

@shenyman
Copy link
Author

shenyman commented Jan 28, 2023 •
edited
Loading

@niden Thanks for your patience! I fixed many things using your #165. I think we can do the PR as you suggested. Can you try the tests please? Thank you!

@shenyman
Copy link
Author

@niden, in your PR #165, you have a commit af30873 where most of the enhancements are related to removing link_to and adding a tag.a (TagFactory). Because I'm installing Vokuro in a subfolder, I noticed that the main links became 'localhost/vokuro/users/users' after an action. Is this because tag.a does not resolve, and should not resolve by design, the correct URL as link_to does?

I've added 'url' resolver to layouts/private.volt only and committed. Not sure if this is the correct way.

@shenyman
Copy link
Author

@niden can we try the tests one more time?

@shenyman
Update composer.json
7fd83be 
edited ext-phalcon to ^5.0.0
@niden niden self-assigned this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niden niden

Labels
Enhancement
Projects
Phalcon v5
Status: Active Sprint
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenyman @niden