-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Adapter for multi-column csv #890
Merged
sergeyklay
merged 19 commits into
phalcon:3.4.x
from
challet:patch-translate-adapter-csvmulti
Mar 7, 2019
Merged
Translate Adapter for multi-column csv #890
sergeyklay
merged 19 commits into
phalcon:3.4.x
from
challet:patch-translate-adapter-csvmulti
Mar 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the last commit (upgrading codeception) fixed this error but broke something else. Help please. |
@challet Looks solid. Could you fix tests? |
@sergeyklay finally done. |
Thank you |
You're welcome |
sergeyklay
pushed a commit
that referenced
this pull request
Jul 27, 2019
* #875: Swiftmailer and Twig are no longer required Moved Swiftmailer and Twig to the Composer "suggest" * Add new validator: ArrayInclusionIn * Fix unit test * Fix unit test - last test method * Support for the TIMESTAMPDIFF * Add options to ReCaptcha Validator to make it work with v3. * Fixed PHPCS issues * fix(oracle): Added missing interface method sharedLock * Moved opening brace to newline as suggested Co-Authored-By: lubber-de <[email protected]> * Translate Adapter for multi-column csv (#890) * [Translate] add an intl MessageFormatter interpolator (#892) * Tidied up READMEs. * Applied PSR2 to tests. * Code standards. * Tidied up Annotations. * Tidied up codebase.
ruudboon
pushed a commit
to ruudboon/incubator
that referenced
this pull request
Aug 30, 2019
ruudboon
added a commit
to ruudboon/incubator
that referenced
this pull request
Aug 30, 2019
* phalcon#875: Swiftmailer and Twig are no longer required Moved Swiftmailer and Twig to the Composer "suggest" * Add new validator: ArrayInclusionIn * Fix unit test * Fix unit test - last test method * Support for the TIMESTAMPDIFF * Add options to ReCaptcha Validator to make it work with v3. * Fixed PHPCS issues * fix(oracle): Added missing interface method sharedLock * Moved opening brace to newline as suggested Co-Authored-By: lubber-de <[email protected]> * Translate Adapter for multi-column csv (phalcon#890) * [Translate] add an intl MessageFormatter interpolator (phalcon#892) * Tidied up READMEs. * Applied PSR2 to tests. * Code standards. * Tidied up Annotations. * Tidied up codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: adding a multi-column csv adapter for the translations.
It might remain a check to be done about the ArrayAccess interface (inherited from Phalcon\Translate\Adapter\Csv)