Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PSR detection via Zephir's Dynamic Class Entries detection #15610

Merged
merged 22 commits into from
Aug 12, 2021
Merged

Improve PSR detection via Zephir's Dynamic Class Entries detection #15610

merged 22 commits into from
Aug 12, 2021

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: new feature | code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson Jeckerson changed the base branch from master to 5.0.x August 6, 2021 21:12
@Jeckerson Jeckerson changed the title Improve PSR compilation via Zephir's Dynamic Class Entries detection Improve PSR detection via Zephir's Dynamic Class Entries detection Aug 6, 2021
@Jeckerson Jeckerson mentioned this pull request Aug 7, 2021
Closed
@Jeckerson Jeckerson marked this pull request as ready for review August 11, 2021 17:39
@Jeckerson Jeckerson requested a review from niden August 11, 2021 17:39
@Jeckerson Jeckerson self-assigned this Aug 11, 2021
@Jeckerson Jeckerson added 5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework labels Aug 11, 2021
@Jeckerson Jeckerson mentioned this pull request Aug 11, 2021
Merged
5 tasks
@niden niden merged commit 68f38aa into 5.0.x Aug 12, 2021
@niden niden deleted the improve-psr-via-zephir branch August 12, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeckerson @remicollet @niden