Delete detailed mode for Class Phalcon\\Debug\\Dump , because the protected and private vars of the object should not be obtained outside.
#13316
Conversation
…n >= 7.2, because I can not get the object protected or private vars.
limingxinleo
changed the title
phalcon/debug/dump.zep
Outdated
| for key, value in variable { | ||
| do { | ||
|
|
||
| let attr = each(variable); |
There was a problem hiding this comment.
Could you please avoid each function. See: #13308
There was a problem hiding this comment.
Sorry, I not find a method to replace each.So I remove detailed mode for Phalcon\\Debug\\Dump . When php version < 7.2, it works.
There was a problem hiding this comment.
Anyway this code will introduce E_DEPRECATED error
There was a problem hiding this comment.
I see, maybe someone can fix it later. I'll try it, too.
tests/unit/DebugTest.php
Outdated
| expect(true)->true(); | ||
| } catch (\Exception $ex) { | ||
| expect(false)->true(); | ||
| } |
There was a problem hiding this comment.
Here is not necessary to use try/catch because tests will fail in case of exception.
There was a problem hiding this comment.
I see , thanks
…rotected and private vars of the object should not be obtained outside.
limingxinleo
changed the title
Phalcon\\Debug\\Dump , because the protected and private vars of the object should not be obtained outside.
|
This is not a good PR, I think the best solution should start with Zephir, not cphalcon. But my level is limited and I'm sorry. |
|
@limingxinleo Closing this in favor of #13332. |
Hello!
Delete detailed mode for Class
Phalcon\\Debug\\Dumpwhen php version >= 7.2, because I can not get the object protected or private vars.Small description of change:
Thanks