Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handles "options" arg on Collection aggregate #12302

Closed
wants to merge 1 commit into from

Conversation

challet
Copy link
Contributor

@challet challet commented Oct 10, 2016

As seen on http://php.net/manual/fr/mongocollection.aggregate.php there is a second argument available for MongoCollection::aggregate.
It accepts for instance a maxTimeMS argument which can be very useful to increase for the aggregation process.

Copy link
Contributor

@Jurigag Jurigag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phalcon/Mvc/Colllection requires changes anyway which are gonna be done in 3.1.0 or later to support both php versions.

@sergeyklay sergeyklay added this to the 3.1.0 milestone Oct 10, 2016
@sergeyklay sergeyklay changed the base branch from 3.0.x to 3.1.x December 11, 2016 19:38
@sergeyklay
Copy link
Contributor

@challet Could you pleas rebase onto 3.1.x, amend CHANGELOG.md and add tests

@challet
Copy link
Contributor Author

challet commented Feb 27, 2017

Hi @sergeyklay, I'm trying to find a documentation about using the tests suite on a custom Phalcon build. Would you have some link to help me with this matter please ?

@sergeyklay sergeyklay modified the milestones: 3.1.0, 3.1.x Mar 22, 2017
@sergeyklay sergeyklay force-pushed the 3.1.x branch 16 times, most recently from 4d3c73f to 6ef079c Compare April 5, 2017 15:25
@sjinks sjinks closed this Apr 26, 2017
@sjinks sjinks reopened this Apr 26, 2017
@sergeyklay sergeyklay modified the milestones: 3.2.x, 3.3.x Oct 14, 2017
@sergeyklay sergeyklay modified the milestones: 3.3.x, 3.4.x Mar 24, 2018
@sergeyklay
Copy link
Contributor

Introduced in the 3.4.x branch. Feel free to open a new issue if the problem appears again. Thank you for contributing.

@sergeyklay sergeyklay closed this May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants