Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Fatal error on route group getHostname #16601

Closed
oleghind opened this issue May 31, 2024 · 1 comment · Fixed by #16602
Closed

[BUG]: Fatal error on route group getHostname #16601

oleghind opened this issue May 31, 2024 · 1 comment · Fixed by #16602
Assignees
@niden @Jeckerson
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@oleghind
Copy link

There is a fatal error when using Route Group without hostname restriction.
PHP Fatal error: Phalcon\Mvc\Router\Group::getHostname(): Return value must be of type string, null returned in Unknown on line 0

I suggest changing functions return type to string | null instead of just string.
@oleghind oleghind added bug A bug report status: unverified Unverified labels May 31, 2024
@niden niden mentioned this issue Jun 1, 2024
Merged
5 tasks
@niden niden self-assigned this Jun 1, 2024
@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Jun 1, 2024
@niden niden added this to Phalcon v5 Jun 1, 2024
@niden niden moved this to In Progress in Phalcon v5 Jun 1, 2024
@Jeckerson Jeckerson self-assigned this Jun 1, 2024
Jeckerson added a commit that referenced this issue Jun 1, 2024
@Jeckerson
#16601 - Fix return type in getHostname() method
d74f42c
Jeckerson added a commit that referenced this issue Jun 1, 2024
@Jeckerson
#16601 - Update changelog
0c50511
@Jeckerson Jeckerson linked a pull request Jun 1, 2024 that will close this issue
#16601 - Fix return type in getHostname() method #16603
Closed
5 tasks
Jeckerson added a commit that referenced this issue Jun 1, 2024
@Jeckerson
#16601 - Update composer.lock
1cd9023
@Jeckerson Jeckerson linked a pull request Jun 1, 2024 that will close this issue
T16601 gethostname #16602
Merged
5 tasks
@niden
Copy link
Member

niden commented Jun 2, 2024

Resolved in #16602

Thank you @oleghind

@niden niden closed this as completed Jun 2, 2024
@niden niden moved this from In Progress to Implemented in Phalcon v5 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon v5
Status: Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T16601 gethostname
#16601 - Fix return type in getHostname() method phalcon/cphalcon
3 participants
@niden @Jeckerson @oleghind