Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI tests for SpeciesAbundance workflow pipeline #11

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Conversation

kylacochrane
Copy link
Collaborator

@kylacochrane kylacochrane commented Mar 25, 2024

This PR adds CI testing to the GitHub Actions (ci.yml), and to the pipeline as a whole: tests/main.nf.test

  • the workflow pipeline (speciesabundance.nf) was updated to accommodate additional testing
  • the test database was separated into two separate directories to expand testing options (now called krakendatabase and brackendatabase, where corresponding files can be found that are accessed by each module).

Various config files were updated accordingly:

  • nextflow.config
  • nextflow_schema.json
  • nf-test.config
  • conf/test.config

The branch has also been tested in Azure.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

@kylacochrane kylacochrane changed the base branch from main to dev March 25, 2024 20:52
@phac-nml phac-nml deleted a comment from github-actions bot Mar 25, 2024
Copy link

github-actions bot commented Mar 25, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dd6bd99

+| ✅ 125 tests passed       |+
#| ❔  26 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/speciesabundance/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/speciesabundance/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-speciesabundance_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-speciesabundance_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-speciesabundance_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowSpeciesabundance.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-speciesabundance_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-speciesabundance_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-speciesabundance_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/speciesabundance/speciesabundance/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-03 17:29:36

@kylacochrane kylacochrane marked this pull request as ready for review March 26, 2024 15:45
@kylacochrane kylacochrane requested a review from apetkau March 26, 2024 15:45
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Thanks so much for all your hard work Kyla 😄 🐙 🥬

I still have to test this out on my computer, but I have comments below.

README.md Outdated Show resolved Hide resolved
tests/main.nf.test Outdated Show resolved Hide resolved
tests/main.nf.test Outdated Show resolved Hide resolved
tests/main.nf.test Outdated Show resolved Hide resolved
tests/main.nf.test Outdated Show resolved Hide resolved
tests/main.nf.test Show resolved Hide resolved
tests/main.nf.test Show resolved Hide resolved
nf-test.config Outdated Show resolved Hide resolved
workflows/speciesabundance.nf Outdated Show resolved Hide resolved
@kylacochrane kylacochrane requested a review from emarinier April 2, 2024 20:08
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks so much Kyla.

Copy link
Member

@emarinier emarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few small comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kylacochrane kylacochrane merged commit 63bc6a0 into dev Apr 3, 2024
4 checks passed
@kylacochrane kylacochrane deleted the CITests branch April 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants