Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 #27

Merged
merged 30 commits into from
Oct 21, 2024
Merged

Release 2.2.0 #27

merged 30 commits into from
Oct 21, 2024

Conversation

sgsutcliffe
Copy link
Contributor

  • Modified the template for input csv file to include a sample_name column in addition to sample in-line with changes to [IRIDA-Next update] as seen with the [speciesabundance pipeline] PR# 26

    • sample_name special characters will be replaced with "_"
    • If no sample_name is supplied in the column sample will be used
    • To avoid repeat values for sample_name all sample_name values will be suffixed with the unique sample value from the input file
  • Fixed linting issues in CI caused by nf-core 3.0.1

Copy link

github-actions bot commented Oct 18, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3c95402

+| ✅ 142 tests passed       |+
#| ❔  29 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-snvphylnfc_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-snvphylnfc_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-snvphylnfc_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowSnvphylnfc.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: params.max_cpus
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-snvphylnfc_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-snvphylnfc_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-snvphylnfc_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/snvphylnfc/snvphylnfc/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-21 14:11:51

@sgsutcliffe sgsutcliffe requested a review from apetkau October 21, 2024 13:58
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much 😄

@sgsutcliffe sgsutcliffe merged commit f1e5fae into main Oct 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants