-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow Execution: Sample Name Cell Component #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksierks
force-pushed
the
sample-name-cell-component
branch
from
July 30, 2024 17:44
b9883a5
to
1c0c55b
Compare
On hold as pipelines failing on validation with sample names that contain spaces. |
ksierks
force-pushed
the
sample-name-cell-component
branch
2 times, most recently
from
August 2, 2024 16:27
2470078
to
4bb67ed
Compare
ericenns
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment, otherwise this looks good.
ksierks
force-pushed
the
sample-name-cell-component
branch
from
August 6, 2024 16:08
c5da1c6
to
8143748
Compare
ericenns
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Simplecov Report
|
Merged
4 tasks
This was referenced Sep 9, 2024
9 tasks
9 tasks
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Updated the
SamplesheetComponent
to include sample names.See http://localhost:3000/rails/lookbook/inspect/nextflow_samplesheet/default.
Fixes #670.
Screenshots or screen recordings
How to set up and validate locally
add-sample-name
to versions within thepipelines.json
file. (Reference https://github.com/phac-nml/iridanextexample/tree/add-sample-name)add-sample-name
.PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.