Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Add timestamps #675

Merged
merged 2 commits into from
Jul 26, 2024
Merged

GraphQL: Add timestamps #675

merged 2 commits into from
Jul 26, 2024

Conversation

ericenns
Copy link
Member

@ericenns ericenns commented Jul 24, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR adds createdAt and updatedAt to all types in GraphQL API by adding a new BaseType which adds these fields. In addition attachmentsUpdateAt has been added to Sample type.

This also updates the GraphQL api to have a default page size of 25.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Start server and navigate to GraphIQL interface (e.g. http://localhost:3000/graphiql)
  2. In Docs view, verify that Attachment, Group, Namespace, Project, User types have createdAt and updatedAt fields
  3. In Docs view, verify that Sample type has createdAt, updatedAt and attachmentsUpdatedAt fields
  4. Execute queries and request the fields above and verify that no errors are raised.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ericenns ericenns added ready for review Pull request is ready for review graphql GraphQL API related changes labels Jul 24, 2024
@ericenns ericenns self-assigned this Jul 24, 2024
Copy link

Simplecov Report

Covered Threshold
92.53% 90%

@malchua
Copy link
Contributor

malchua commented Jul 25, 2024

Looks good to me. Never got any errors when executing.

Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChrisHuynh333 ChrisHuynh333 merged commit edfde24 into main Jul 26, 2024
3 checks passed
@ericenns ericenns deleted the graphql/add-timestamps branch August 7, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql GraphQL API related changes ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants