Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DEV to MAIN following Nextflow plugin version pinning and Azure testing. #13

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

kylacochrane
Copy link
Collaborator

After issue #11 was resolved regarding the pinning of nextflow plugin versions via PR #12, the dev branch of the pipeline was run on the Azure system (NMLGC-GSP-SBX subscription) and completed successfully.

The DEV branch can now be merged with the MAIN branch.

PR checklist

  • This comment contains a description of changes (with reason).

@kylacochrane kylacochrane requested a review from apetkau February 23, 2024 20:08
Copy link

github-actions bot commented Feb 23, 2024

nf-core lint overall result: Failed ❌

Posted for pipeline commit cc8f996

+| ✅ 116 tests passed       |+
#| ❔  27 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   6 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/WorkflowFetchdatairidanext.groovy
  • files_exist - File must be removed: lib/nfcore_external_java_deps.jar
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.1
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/fetchdatairidanext/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/fetchdatairidanext/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-fetchdatairidanext_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-fetchdatairidanext_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-fetchdatairidanext_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-fetchdatairidanext_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-fetchdatairidanext_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-fetchdatairidanext_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchdatairidanext/fetchdatairidanext/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.13
  • Run at 2024-02-23 20:09:22

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 😄

@kylacochrane kylacochrane merged commit d9657e7 into main Feb 23, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants