code review followup

pgomulka · Jul 10, 2024 · a363a8f · a363a8f
1 parent 6c13ca7
commit a363a8f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/...c/internalClusterTest/java/org/elasticsearch/plugins/internal/DocumentSizeObserverIT.java b/...c/internalClusterTest/java/org/elasticsearch/plugins/internal/DocumentSizeObserverIT.java
@@ -109,8 +109,7 @@ public IndexResult index(Index index) throws IOException {
                         DocumentSizeAccumulator.EMPTY_INSTANCE
                     );
                     ParsedDocument parsedDocument = index.parsedDoc();
-                    DocumentSizeObserver documentSizeObserver = parsedDocument.getDocumentSizeObserver();
-                    documentParsingReporter.onIndexingCompleted(documentSizeObserver);
+                    documentParsingReporter.onIndexingCompleted(parsedDocument);
 
                     return result;
                 }
@@ -151,8 +150,8 @@ public TestDocumentSizeReporter(String indexName) {
         }
 
         @Override
-        public void onIndexingCompleted(DocumentSizeObserver documentSizeObserver) {
-            COUNTER.addAndGet(documentSizeObserver.normalisedBytesParsed());
+        public void onIndexingCompleted(ParsedDocument parsedDocument) {
+            COUNTER.addAndGet(parsedDocument.getDocumentSizeObserver().normalisedBytesParsed());
             assertThat(indexName, equalTo(TEST_INDEX_NAME));
         }
     }

diff --git a/server/src/main/java/org/elasticsearch/plugins/internal/DocumentSizeReporter.java b/server/src/main/java/org/elasticsearch/plugins/internal/DocumentSizeReporter.java
@@ -8,6 +8,8 @@
 
 package org.elasticsearch.plugins.internal;
 
+import org.elasticsearch.index.mapper.ParsedDocument;
+
 /**
  * An interface to allow performing an action when parsing and indexing has been completed
  */
@@ -21,10 +23,10 @@ public interface DocumentSizeReporter {
     /**
      * An action to be performed upon finished indexing.
      */
-    default void onParsingCompleted(DocumentSizeObserver documentSizeObserver) {}
+    default void onParsingCompleted(ParsedDocument parsedDocument) {}
 
     /**
      * An action to be performed upon finished indexing.
      */
-    default void onIndexingCompleted(DocumentSizeObserver documentSizeObserver) {}
+    default void onIndexingCompleted(ParsedDocument parsedDocument) {}
 }