Fix NumericDecodeUtils.decodeBinary(byteBuf) decoding
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrong result for BigDecimal between 1 and -1
mp911de
changed the title
NumericDecodeUtils.decodeBinary(byteBuf) decoding
mp911de
added a commit
that referenced
this pull request
Nov 9, 2022
Replace String.format(…) with our own digit rendering and padding to reduce computation on hot code paths. [resolves #558][#556] Signed-off-by: Mark Paluch <[email protected]>
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…result for BigDecimal between 1 and -1
Make sure that:
Issue description
I use the some test data as in https://github.com/pgjdbc/pgjdbc/blob/a29767eaa27b97a68c21dee04e8483872783f2e2/pgjdbc/src/test/java/org/postgresql/util/BigDecimalByteConverterTest.java plus some more data.
To create the BigDecimal in binary format, I use the util method ByteConverter.numeric provided by the jdbc postgres drivers.