-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend PostgresqlSqlLexer
to handle PG14 SQL-standard function body syntax
#512
Labels
type: enhancement
A general enhancement
Milestone
Comments
/cc @toverdijk |
It does seem quite complex - I guess also the sql body needs to be parsed completely as well in order to catch commented out ENDs and such. I'll give it a shot.. |
4 tasks
mp911de
pushed a commit
that referenced
this issue
May 25, 2022
mp911de
added a commit
that referenced
this issue
May 25, 2022
Reorder methods. Use CharObjectMap for operator character lookup instead of linear array iteration. Extract peek/has next token functionality into dedicated methods. Migrate assertions to AssertJ. Add benchmark. [#512][resolves #513] Signed-off-by: Mark Paluch <[email protected]>
mp911de
pushed a commit
that referenced
this issue
May 25, 2022
mp911de
added a commit
that referenced
this issue
May 25, 2022
Reorder methods. Use CharObjectMap for operator character lookup instead of linear array iteration. Extract peek/has next token functionality into dedicated methods. Migrate assertions to AssertJ. Add benchmark. [#512][resolves #513] Signed-off-by: Mark Paluch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PG14 added a new syntax for creating SQL functions that we should support with
PostgresqlSqlLexer
Right now,
PostgresqlSqlLexer.tokenize(…)
identifies this above as two statements. See also:The text was updated successfully, but these errors were encountered: