fix: deprecated PGPoolingDataSource #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 42.0.0, instead of this class you should use a fully featured connection pool like HikariCP, vibur-dbcp, commons-dbcp, c3p0, etc. It also deprecates the backwards compatibility classes of DataSource with a link to the correct implementation. closes pgjdbc#729
Current coverage is 64.32% (diff: 100%)@@ master #739 diff @@
==========================================
Files 163 163
Lines 15140 15140
Methods 0 0
Messages 0 0
Branches 2987 2987
==========================================
- Hits 9741 9739 -2
- Misses 4159 4160 +1
- Partials 1240 1241 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated PGPoolingDataSource instead of this class you should use a fully featured connection pool
like HikariCP, vibur-dbcp, commons-dbcp, c3p0, etc.
It also deprecates the backwards compatibility classes of DataSource with a link
to the correct implementation.
closes #729