Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.3: Update for full compatibility with zeitwerk #824

Merged
merged 5 commits into from
Oct 5, 2024
Merged

Conversation

danigirl329
Copy link
Member

  • Removes the gem loader for extensions as this has been deprecated for a while
  • Rewrites the module MultiSite::ScopedValidation to use prepend methods as this was causing a stack error when making changes and reloading
  • Comment out dependency observer. This should no longer be needed for zeitwerk should be autoloading extensions and dependencies.
  • Shows that in the new world, config.to_prepare should be utilized instead of after_initialize. This file makes no difference but when the engine is installed this configuration will be passed on to the app that is installing trusty-cms. The .to_prepare will direct the app to reload what is inside this block, so instead of using the dependency observer, the app will deactivate and reactive extensions inside this block instead.
  • Register v6.3 on rubygems

@danigirl329 danigirl329 merged commit f6446ab into master Oct 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant