Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets breaking on pages/edit #743

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix assets breaking on pages/edit #743

merged 1 commit into from
Nov 21, 2023

Conversation

danigirl329
Copy link
Member

  • Push assets to the search partial from the asset popup << add ransack term ivar to the edit controller, and I needed to add an edit controller to introduce some functionality to it.
  • Reintroduce autocomplete using the ransack params - I realized that you can't search in the popup without it. Pressing enter just redirects to assets tab page. Not helpful.
  • Add a pause before the search starts on keyup to avoid mixups in search. I noticed that in testing this - if i was typing out my search sometimes what I type was out of order in the search action. For example, searching "Benedum" I would see

cache: [GET /admin/assets?search[title_cont]=bene&pp=50] miss
cache: [GET /admin/assets?search[title_cont]=benedum&pp=50] miss
cache: [GET /admin/assets?search[title_cont]=ben&pp=50] miss

...Causing the results to return all images using ben instead of benedum. Adding the pause should reduce that greatly if not entirely.

@Crankums Crankums merged commit 6ea8011 into master Nov 21, 2023
7 checks passed
@Crankums Crankums deleted the assets-updates-v2 branch November 21, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants