Upgrade trusty-cms to use Active Storage and Deprecate Paperclip #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-uri for kraken.
…or the new super long urls
…ed next bundle on other sites Remove paperclip references / interpolation file Rewrite the thumbnail method to check if the file can be variable (change sizes) and if so, return the proper one according to style. I'm not sure this is the best way to write this yet. Maybe we should consider creating a variant model or something to store thumbnail and original and normal styles/sizes? Still noodling on that one.
… no new method or an active storage named method.
|
Closes #251 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove paperclip gem and replace with file validators, active storage, and image processing
replace model methods for paperclip with active storage
Update to version 5 of trusty cms
Instead of using config for image sizes, add preset sizes for normal, thumbnail, small and icon