Add a Rust version check to cargo-pgx #873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had done part of this a while ago, and it came up recently, so I cleaned it off.
Fixes #774, although in the future I would like to relax this requirement and remove this check.
It does not detect mismatches between 1.x.0 and 1.x.1 (which should be fine), or between different betas/nightlies (which is probably strictly required, but would be personally pretty annoying for me).
It tends to ignore errors rather than failing, in case something in the output of one of the tools changes (unlikely, given how much of the ecosystem uses checks like this). There's also an escape-hatch environment variable called
PGX_IGNORE_RUST_VERSIONS
to disable the check.I only check in the schema generation code, since that's the only code that needs to care about this.