fix: crash from drop impls that panic via leak_and_drop_on_delete()
#1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `PgMemoryContexts::leak_and_drop_on_delete()` leaks a type that `impl Drop`, and that implementation happens to panic, then Postgres will segfault because the callback function was not properly guarded. As a drive-by, slightly cleanup error reporting in the test framework.
eeeebbbbrrrr
commented
Oct 27, 2024
Comment on lines
+558
to
+559
| use crate as pgrx; | ||
| #[pgrx::pg_guard] |
There was a problem hiding this comment.
the actual fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
PgMemoryContexts::leak_and_drop_on_delete()leaks a type that isimpl Drop, and that implementation happens to panic, then Postgres will segfault because the callback function was not properly guarded.As a drive-by, slightly cleanup error reporting in the test framework.