Split out pgrx-bindgen crate #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
added a commit
that referenced
this pull request
Aug 13, 2024
Found a bug after doing some refactoring to improve how this tool works in general, making it more resilient to whatever the hell we do to our repo. This should allow us to have packages with different names than the paths to them, allowing arbitrary nesting and relocation, and also applies a less ad-hoc rule regarding "what packages are we updating". Unblocks #1802.
workingjubilee
force-pushed
the
split-out-pgrx-bindgen
branch
from
a7f6f58
to
d285b92
Compare
workingjubilee
force-pushed
the
split-out-pgrx-bindgen
branch
from
e67f6a4
to
6178093
Compare
|
The packaging test generates a sufficiently large cache that it cannot be done for every version of pgrx in the combinatoric fashion that we usually do, thus, we don't anymore! We simply run it for one version. |
|
Which predictably drops several minutes off CI! Nice. Let's go! |
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last essentially-administrative change, and part of the reason that I did all the mucking-about in #1796. We have a lot of code in pgrx-pg-sys's build.rs, and it's high time that we actually split out the real crate that it is. Currently this just moves that around, rather than doing any refactoring, to make the git blame trackable.
The packaging test generates a sufficiently large cache that it cannot be done for every version of pgrx in the combinatoric fashion that we usually do, thus, we don't anymore! We simply run it for one version.