Rename ErrorReportable::report() to unwrap_or_report()
#1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
This looks great! (assuming CI also approves)
Just to remind though, we have the best versioning scheme: https://0ver.org/
workingjubilee
changed the title
ErrorReportable::report() to unwrap_or_report()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1561,
pgrx::pg_sys::panics::ErrorReportable::report()is named identically tostd::process::Termination::report(), and they are both traits that are implemented onResult<T, E>so if you import both traits you'll have a name collision. Aside from the name collision, it's very easy to see.report()called on aResulttype and make the incorrect assumption this is theTerminationtrait when one is unfamiliar with PGRX's codebase.To avoid ambiguity, this set of changes renames that method to
unwrap_or_report(), and is intended to be included in the set of breaking changes for 0.12.