Change SHOW USERS to list connections #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchub
reviewed
Mar 13, 2024
doc/usage.md
Outdated
| for this specific user, then the default value will be displayed. | ||
|
|
||
| current_connections | ||
| : Current number of connections that this user has open to the server. |
There was a problem hiding this comment.
Instead of "has open to the server", I think it would be more useful (and more accurate, given your code) to be "has open to all servers."
While reviewing pgbouncer#1039 I had a hard time max_user_connections seeing if max_user_connections was applied correctly because `SHOW USERS` didn't list it. This addresses that by adding a `max_user_connections` and `current_connections` column to the output of `SHOW USERS`.
JelteF
force-pushed
the
admin-max_user_connections
branch
from
824838e
to
e016d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #1039 I had a hard time seeing if
max_user_connections was applied correctly because
SHOW USERSdidn'tlist it. This addresses that by adding a
max_user_connectionsandcurrent_connectionscolumn to the output ofSHOW USERS.