Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused requests dependency #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused requests dependency #123

wants to merge 1 commit into from

Conversation

jgarte
Copy link

@jgarte jgarte commented Oct 29, 2022

No description provided.

@pganssle
Copy link
Owner

I'm a bit torn on this one. This isn't really a dependency per se, it's just saying that requests is a third party library that should be sorted with third party libraries. I don't think it's hurting anything to leave it there, and might be mildly less annoying if we ever start using requests in something we're formatting with isort.

On the other hand, YAGNI, so I'm inclined to merge anyway. Anyone have strong arguments one way or the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgarte @pganssle