Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure update_source always works from a clean state #117

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Ensure update_source always works from a clean state #117

merged 1 commit into from
Aug 14, 2024

Conversation

seanlinsley
Copy link
Member

If make clean isn't called before make update_source, changes to LIB_PG_QUERY_TAG won't take effect because of the locally cached state. Fix that by ensuring clean is a dependency for update_source so it's always called first.

@seanlinsley seanlinsley requested a review from a team August 6, 2024 16:33
keiko713
keiko713 approved these changes Aug 14, 2024
View reviewed changes
Copy link

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is safe and makes sense (make clean works okay even without tmp folder) 👍
Unrelated but curious: do we have any docs for these command?

@seanlinsley seanlinsley merged commit 8c00be8 into main Aug 14, 2024
5 checks passed
@seanlinsley seanlinsley deleted the update_source_fix branch August 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiko713 keiko713 keiko713 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlinsley @keiko713