Use groupadd instead of addgroup #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter seems to no longer be available on Amazon Linux 2023. Since addgroup is just a convenience wrapper around groupadd and we are only using its basic functionality, we can switch to using groupadd directly.
msakrejda
commented
Nov 13, 2024
| @@ -8,7 +8,7 @@ if ! getent passwd pganalyze > /dev/null; then | |||
| fi | |||
|
|
|||
| if ! getent group pganalyze > /dev/null; then | |||
| addgroup --system --quiet pganalyze | |||
| groupadd --system pganalyze | |||
There was a problem hiding this comment.
--quiet is not an option for groupadd, but the command produces no output anyway, so the flag is moot.
keiko713
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter seems to no longer be available on Amazon Linux 2023. Since
addgroup is just a convenience wrapper around groupadd and we are only
using its basic functionality, we can switch to using groupadd
directly.