Build more regular expressions at boot time #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlinsley
force-pushed
the
logs-memory
branch
from
4045b50
to
637d623
Compare
seanlinsley
commented
Oct 5, 2024
seanlinsley
force-pushed
the
logs-memory
branch
from
637d623
to
cf94c4a
Compare
seanlinsley
changed the title
seanlinsley
changed the title
|
TIL: despite Go being a compiled language, these variables are actually defined when the program boots, not when it's compiled https://stackoverflow.com/a/72185182 |
msakrejda
approved these changes
Oct 8, 2024
| // We ignore failures here since we want the per-backend stitching logic | ||
| // that runs later on (and any other parsing errors will just be ignored). | ||
| // Note that we need to restore the original trailing newlines since | ||
| // AnalyzeStreamInGroups expects them and they are not present in the GCP | ||
| // log stream. | ||
| logLine, _ := parser.ParseLine(in.Content + "\n") | ||
| logLine, _ := server.GetLogParser().ParseLine(in.Content + "\n") |
There was a problem hiding this comment.
No big deal, but if we get a nil panic here, it now won't be clear if server is nil or GetLogParser() returned nil (or in is nil, but that was the case before).
There was a problem hiding this comment.
Since in is coming from a channel and we check ok, I think it's impossible for in to be nil. But even if it was, lines of code above this would have already panicked by accessing in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For support ticket 5773, I noticed that some places in the code we compile regular expressions at runtime for regular expressions that don't change. This PR fixes that, which should reduce CPU/memory usage.