Error out on incomplete config sections #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msakrejda
commented
Aug 27, 2024
|
The |
Merged
keiko713
reviewed
Aug 28, 2024
|
This now include some other minor cleanup, in separate commits. |
lfittl
reviewed
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer ran into this because they specified some configuration settings in uppercase (
DB_NAME). We currently silently skip incomplete sections, which is pretty confusing.Separately, I considered parsing config keys in a case-insensitive manner, but since some but not all of our environment variable keys are identical to our config file keys, I thought this would be more confusing than a clear error. I'm open to revisiting that decision.