Docker log tail: Re-order args to also support podman aliased as docker #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst we currently explicitly call out to "docker" for this experimental way of reading local logs during development, we technically also support podman when its available with the "docker" alias. However, podman requires arguments to be set before the container name. Fix support for this type of setup. This keeps compatibility with docker, which accepts arguments in either order.
msakrejda
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst we currently explicitly call out to "docker" for this experimental way of reading local logs during development, we technically also support podman when its available with the "docker" alias. However, podman requires arguments to be set before the container name. Fix support for this type of setup. This keeps compatibility with docker, which accepts arguments in either order.