Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Parsing: Fix crash in --analyze-logfile option #443

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Log Parsing: Fix crash in --analyze-logfile option #443

merged 1 commit into from
Aug 7, 2023

Conversation

lfittl
Copy link
Member

@lfittl lfittl commented Aug 5, 2023

Due to the changes in 7b67039 we need to always initialize the server mutex for the log parsing functions.

@lfittl
Log Parsing: Fix crash in --analyze-logfile option
74da83b 
Due to the changes in 7b67039 we need
to always initialize the server mutex for the log parsing functions.
@lfittl lfittl requested a review from msakrejda August 5, 2023 20:42
msakrejda
msakrejda approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@msakrejda msakrejda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Maybe we should add a --analyze-logfile test to our full suite, but no need to do that now.

@lfittl lfittl merged commit fa0288e into main Aug 7, 2023
6 checks passed
@lfittl lfittl deleted the fix-analyze-logfile-option branch August 7, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msakrejda msakrejda msakrejda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfittl @msakrejda