Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema diff - Timeout error is not handled when pgAdmin4 is hosted on Apache/Httpd (RM #7104) #4841

Closed
dpage opened this issue Jan 7, 2022 · 12 comments
Assignees
Milestone

Comments

@dpage
Copy link
Contributor

dpage commented Jan 7, 2022

Issue migrated from Redmine: https://redmine.postgresql.org/issues/7104
Originally created by Murtuza Zabuawala at 2022-01-07 06:32:35 UTC.

Newer version of httpd on CentOS/Redhat has very low TimeOut value by default - 60 sec
So if schema diff takes longer than that it throws blank error popup.

Refer attached screenshot.

Expected - Display proper error instead of blank popup.

@dpage
Copy link
Contributor Author

dpage commented Jan 7, 2022

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/6555
Originally created by Murtuza Zabuawala at 2022-01-07 06:30:40 UTC.

Screenshot_2022-01-07_at_11.59.51_AM.png

Filename: Screenshot_2022-01-07_at_11.59.51_AM.png

@dpage
Copy link
Contributor Author

dpage commented Jan 7, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-2
Originally created by Murtuza Zabuawala at 2022-01-07 07:09:12 UTC.

If we can use utilize https://docs.python.org/3/library/asyncio.html for comparing objects logic, i think comparison would be faster.

@dpage
Copy link
Contributor Author

dpage commented Jan 7, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-3
Originally created by Aditya Toshniwal at 2022-01-07 09:54:21 UTC.

pgAdmin supports Python 3.6+ and asyncio is available from 3.7.

@dpage
Copy link
Contributor Author

dpage commented Jan 7, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-4
Originally created by Yogesh Mahajan at 2022-01-07 11:21:07 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready

@dpage
Copy link
Contributor Author

dpage commented Jan 11, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-5
Originally created by Murtuza Zabuawala at 2022-01-11 06:44:02 UTC.

Hello Aditya,

The asyncio module is part of the Python standard library since Python 3.4. In version 3.7, they introduced .run() method which was not available earlier though there was another way to run it.

@dpage
Copy link
Contributor Author

dpage commented Jan 19, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-6
Originally created by Akshay Joshi at 2022-01-19 10:20:29 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready EDB Sprint 109

@dpage
Copy link
Contributor Author

dpage commented Jan 26, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-7
Originally created by Akshay Joshi at 2022-01-26 17:21:22 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 109 EDB Sprint 110

@dpage
Copy link
Contributor Author

dpage commented Feb 16, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-8
Originally created by Akshay Joshi at 2022-02-16 10:24:15 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 110 Ready

@dpage
Copy link
Contributor Author

dpage commented Mar 30, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-9
Originally created by Akshay Joshi at 2022-03-30 10:45:33 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready EDB Sprint 114

@dpage
Copy link
Contributor Author

dpage commented Apr 5, 2022

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7104#note-10
Originally created by Akshay Joshi at 2022-04-05 05:30:21 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 114 Ready

@adityatoshniwal
Copy link
Contributor

This can be handled with SocketIO lib which pgAdmin is already using in psql and in ERD to fetch database tables data.

@FaharAbbasRizvi
Copy link
Contributor

Tested on candidate build for v6.16.

@FaharAbbasRizvi FaharAbbasRizvi moved this from In Testing to ✅ Done in Current Sprint (184) Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants