Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astar code simplification #2517

Merged
merged 26 commits into from
May 19, 2023
Merged

Astar code simplification #2517

merged 26 commits into from
May 19, 2023

Conversation

cvvergara
Copy link
Member

Changes proposed in this pull request:

  • Removes unused code
  • astar is now a function not a class

@pgRouting/admins

@cvvergara
[astar][C++] pgr_astar.hpp -> astar.hpp
f279e2b
@cvvergara
[astar] adjusting code to previous change
93ac11c
@cvvergara
[astar][visitors] moving visitors to different file
47a752c
@cvvergara
[astar] adjusting code to moving visitors
237c5ef
@cvvergara
[astar]:broom: deleting unused code
316f708
@cvvergara
[astar] marking unused code
f76a2ed
@cvvergara
[astar] marking unused code
5349680
@cvvergara
[astar]:broom: deleting unused code
6c4dfff
@cvvergara
[astar][C++] Using combinations for departures & destinations
ec4deaf
@cvvergara
[astar] adjusting code because it uses only combinations
10902ce
@cvvergara
[astar] marking unused code
cb253e8
@cvvergara
[astar] cleaning unused code & using std::set
e73c701
@cvvergara
[astar] distance_heuristic -> anonymus namespace
f29ad5d
@cvvergara
[astar] adjusting code for previous change
f4ccb24
@cvvergara
[astar] get_paths -> anonymous namespace, & adjusted code
0496e31
@cvvergara
[astar] astar_1_to_many -> anonymous namespace
02531ed
@cvvergara
[astar] adusting code because of change on astar_1_to_many
1823ae1
@cvvergara
[astar] Removing function by moving code within another function
bf8d60a
@cvvergara
[astar]:broom: removing unused code
760d520
@cvvergara
[astar] class do not have data members
12ded52
@cvvergara
[astar] class -> function
923cb22
@cvvergara
[astar] lint code & removing unused code
72e6166
@cvvergara
[astar] using the function directly on the driver
1e15270
@cvvergara
[astar] cleaning up code, licenses, pgr_ C call
850c449
@cvvergara cvvergara added this to the Release 3.6.0 milestone May 18, 2023
@cvvergara cvvergara marked this pull request as ready for review May 18, 2023 17:57
@cvvergara cvvergara merged commit 54199cd into pgRouting:develop May 19, 2023
@cvvergara cvvergara deleted the astar-code-simplification branch May 19, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omshinde omshinde omshinde approved these changes

@dkastl dkastl Awaiting requested review from dkastl

@robe2 robe2 Awaiting requested review from robe2

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@AbhinJ AbhinJ Awaiting requested review from AbhinJ

@krashish8 krashish8 Awaiting requested review from krashish8

@aryan1010 aryan1010 Awaiting requested review from aryan1010

@shobhit162 shobhit162 Awaiting requested review from shobhit162

@squarege squarege Awaiting requested review from squarege

@Aniket-debug Aniket-debug Awaiting requested review from Aniket-debug

Assignees
No one assigned
Labels
Astar C/C++
Projects
None yet
Milestone
Release 3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @omshinde