De-vendor pex just once per version. #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would de-vendor pex once per CLI invocation in a new temporary directory. Now we de-vendor once per pex version under the pex root (~/.pex/isolated/...) by leveraging existing hashing and atomic directory creation tools.
benjyw
approved these changes
Dec 27, 2019
Eric-Arellano
approved these changes
Dec 27, 2019
This results in a nominal performance decrease but it's in the wash - O(10ms) slower on non-spinning disk. The speed win will come when the content hash of the pex distribution is stored in a metadata file in the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would de-vendor pex once per CLI invocation in a new
temporary directory. Now we de-vendor once per pex version under the
pex root (~/.pex/isolated/...) by leveraging existing hashing and atomic
directory creation tools.