Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vendored setuptools to 42.0.2. #832

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Dec 26, 2019

The changelogs from 41.6.0 are here:
https://setuptools.readthedocs.io/en/latest/history.html#v42-0-2

Of most note are the changes to setuptools to use pip when present
to implement setup_requires. The way we invoke pip in pex/pip.py
is compatible with this new feature; so we get more successful wheel
builds as a result.

See: pypa/setuptools#1830

The changelogs from 41.6.0 are here:
  https://setuptools.readthedocs.io/en/latest/history.html#v42-0-2

Of most note are the changes to setuptools to use pip when present
to implement `setup_requires`. The way we invoke pip in pex/pip.py
is compatible with this new feature; so we get more successful wheel
builds as a result.

See: pypa/setuptools#1830
@jsirois
Copy link
Member Author

jsirois commented Dec 26, 2019

Reviewers, note that the only manual change here was the single line edit to pex/vendor/__init__.py.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great to learn that setuptools is now using Pip for this. Thanks!

@jsirois jsirois merged commit 70353ba into pex-tool:master Dec 27, 2019
@jsirois jsirois deleted the setuptools/upgrade branch December 27, 2019 18:09
@jsirois jsirois mentioned this pull request Dec 28, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants