Fix pex resolution to respect --ignore-errors. #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pip might warn in red that versions were mismatched but we would get no failure until pex runtime resolution. Improve pex runtime resolution error messages and implement pex buildtime resolution sanity checks when --no-ignore-errors.
jsirois
requested review from
Eric-Arellano,
cosmicexplorer,
asherf and
kwlzn
Eric-Arellano
approved these changes
Dec 12, 2019
pex/package.py
Outdated
| return False | ||
| # This supports resolving pex's own vendored distributions which are vendored in directory | ||
| # directory with the project name (`pip/` for pip) and not the corresponding wheel name | ||
| # (`pip-19.3.1-py2.py3-none-any.whl/` for pip). Pes only vendors universal wheels for all |
benjyw
added a commit
to benjyw/pex
that referenced
this pull request
Apr 15, 2020
PR pex-tool#828 introduced a bug in the code that gathers the requirers of requirements that failed to be resolved (so that we can display those requirers in an error message.) Specifically, reqs_by_key's values are lists of requirements, so we need to call update() on each such value separately.
benjyw
added a commit
that referenced
this pull request
Apr 16, 2020
PR #828 introduced a bug in the code that gathers the requirers of requirements that failed to be resolved (so that we can display those requirers in an error message.) Specifically, reqs_by_key's values are lists of requirements, so we need to call update() on each such value separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pip might warn in red that versions were mismatched but
we would get no failure until pex runtime resolution. Improve pex
runtime resolution error messages and implement pex buildtime
resolution sanity checks when --no-ignore-errors.
At buildtime we now get:
And the corresponding runtime error is now: