Use flit to distribute pex. #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of the tricky setup.py setuptools and wheel bootstrapping we were doing using pex vendored versions and gives us non-deprecated publishing support. In the course of adding a pyproject.toml for flit, also update pex distribution metadata to officially support Python 3.8 with 1 test tweak. CI for Python 3.8 will come in a follow-up change. Fixes pex-tool#805 Fixes pex-tool#807
jsirois
force-pushed
the
issues/805-807
branch
from
d32f3e4 to
12588a5
Compare
Eric-Arellano
approved these changes
Dec 12, 2019
| @@ -1,2 +0,0 @@ | |||
| [wheel] | |||
| universal = 1 | |||
There was a problem hiding this comment.
Are we still marking this somehow? I don't see it in pyproject.toml.
There was a problem hiding this comment.
Its an implication of requires-python = ">=2.7,<3.9,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*"
If you run flit build you'll see a universal wheel gets plopped to dist/. There is no tox target for this, just tox -e publish, but that's safe to run since pypi does not allow over-writes.
codealchemy
reviewed
Dec 12, 2019
|
|
||
| from pex.version import __version__ as __pex_version__ | ||
|
|
||
| __version__ = __pex_version__ # N.B.: Flit uses this as out distribution version. |
There was a problem hiding this comment.
s/out/our ?
Edit: Just caught this came in after the merge, my mistake.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jan 6, 2020
This was missed in pex-tool#826 but noticed creating pex-tool#842 where pex.pex startup was slower than expected due to not using the current (python 3.8) interpreter and instead proceeding to find all interpreters and then select the min.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jan 7, 2020
This was a flub in pex-tool#826.
Merged
jsirois
added a commit
that referenced
this pull request
Dec 24, 2023
This was no longer needed with the switch to the flit PEP-517 builder back in #826 in 2019.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the tricky setup.py setuptools and wheel bootstrapping
we were doing using pex vendored versions and gives us non-deprecated
publishing support. In the course of adding a pyproject.toml for flit,
also update pex distribution metadata to officially support Python 3.8
with 1 test tweak. CI for Python 3.8 will come in a follow-up change.
Fixes #805
Fixes #807
Work towards #806