Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #794 issue by add missing return statement in __str__ #795

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

Djailla
Copy link
Contributor

@Djailla Djailla commented Nov 15, 2019

Fixing issue #794, every build failed using --index-url option

@Djailla
Copy link
Contributor Author

Djailla commented Nov 15, 2019

Hello @jsirois if this PR could be embedded into a fix release that would be great ! It's blocking my team and teammates 👍

Copy link
Member

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will be included in the 2.0.1 release tomorrow along with a few other fixes.

@Djailla
Copy link
Contributor Author

Djailla commented Nov 18, 2019

Thanks a lot !

@jsirois jsirois merged commit c0b9ec3 into pex-tool:master Nov 18, 2019
@Djailla Djailla deleted the fix_794 branch November 18, 2019 23:58
@Djailla
Copy link
Contributor Author

Djailla commented Nov 19, 2019

Hello @jsirois is the 2.0.1 release still scheduled for today ?

@jsirois
Copy link
Member

jsirois commented Nov 19, 2019

Yes.

jsirois added a commit to jsirois/pex that referenced this pull request Nov 20, 2019
Previously rendering was broken but fixed in pex-tool#795. Add a test of that
fix.
jsirois added a commit that referenced this pull request Nov 20, 2019
Previously rendering was broken but fixed in #795. Add a test of that
fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants