PythonInterpreter: support python binary names with single letter suffixes #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murph
force-pushed
the
murph/pex/regexen
branch
from
0ddd49a
to
5eff2ef
Compare
jsirois
reviewed
Oct 2, 2019
| @@ -267,6 +267,10 @@ class PythonInterpreter(object): | |||
|
|
|||
| re.compile(r'python[23]$'), | |||
| re.compile(r'python[23].[0-9]$'), | |||
|
|
|||
| # PEP-3149: Python implementations MAY include additional flags in the file name tag | |||
| re.compile(r'python[23].[0-9][a-z]$'), | |||
There was a problem hiding this comment.
You've found cases of this in the wild and that may be more important to mention since, IIUC, that pep refers to .so names and not python interpreter names.
murph
force-pushed
the
murph/pex/regexen
branch
from
5eff2ef
to
53d53c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gentoo linux, my python binaries have the 'm' suffix, and then are symlinked from the non-suffixed versions:
usr/bin/python3.5 -> python3.5m
/usr/bin/python3.5m
/usr/bin/python3.6 -> python3.6m
/usr/bin/python3.6m
etc.
PEP-3149 indicates this is okay, so pex should probably support it.
I updated a test, but already have a bunch of tox failures on master so it's hard to know if it passes:
"15 failed, 61 passed, 3 skipped, 1 xfailed in 198.12 seconds"
I'll dig into that in another branch hopefully =)