Include PYTHONPATH in --inherit-path logic.
#765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Pex would inherit `PYTHONPATH` by default despite the default `--inherit-path` setting being false. This was buggy behavior running against the primary Pex goal of providing an isolated execution environment. Now, to use PYTHONPATH to ammend the `sys.path` of a running is accomplished by either of: ``` PEX_INHERIT_PATH=prefer PYTHONPATH=... ./my.pex PEX_INHERIT_PATH=fallback PYTHONPATH=... ./my.pex ``` Update corresponding settings documentation and fix pex to consider PYTHONPATH when adjusting sys.path. Fixes pex-tool#707
| return pex_info | ||
|
|
||
| def assert_isolation(self, inherit_path, expected_output): | ||
| env = dict(PYTHONPATH=self.pythonpath) |
There was a problem hiding this comment.
Nit: collection literal preferred, per Pants style guide. Not worth losing sleep over or fixing retroactively, though.
There was a problem hiding this comment.
Hrm, that definitely is not the style guide used in PEX today.String interpolation doesn't even apply for example due to PEX supporting 2.7. Even if it did though, this one I might have wanted to debate a little. For dicts in particular, dict can be viewed as nicer than a literal since the kwarg form used here puts sane restrictions on env var keys as well as making them appropriately "pop out" visually in syntax highlighters. Thats why I tend to use it for env dicts anyhow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Pex would inherit
PYTHONPATHby default despite the default--inherit-pathsetting being false. This was buggy behavior runningagainst the primary Pex goal of providing an isolated execution
environment. Now, to use PYTHONPATH to amend the
sys.pathof arunning is accomplished by either of:
Update corresponding settings documentation and fix pex to consider
PYTHONPATH when adjusting sys.path.
Fixes #707